Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(download): include Year column for explorers when its slug isn't "year" #4445

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Jan 14, 2025

Fixes https://owid.slack.com/archives/C46U9LXRR/p1736789183540029.

The problem: For this explorer, the year column slug is not year, but Year.

The solution: Use the existing code that auto-detects a time column to use.

@marcelgerber marcelgerber force-pushed the explorers-fix-download-year-col branch from fdabdf5 to 5d547d8 Compare January 14, 2025 07:56
@marcelgerber marcelgerber requested a review from danyx23 January 14, 2025 07:57
@owidbot
Copy link
Contributor

owidbot commented Jan 14, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-explorers-fix-download-year

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-14 08:14:08 UTC
Execution time: 1.18 seconds

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch - thanks for the fix!

@marcelgerber marcelgerber merged commit 5537ae3 into master Jan 14, 2025
26 checks passed
@marcelgerber marcelgerber deleted the explorers-fix-download-year-col branch January 14, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants